dajac commented on a change in pull request #11903:
URL: https://github.com/apache/kafka/pull/11903#discussion_r829300000
##########
File path:
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java
##########
@@ -57,7 +61,10 @@ public R apply(R record) {
final Matcher matcher = regex.matcher(record.topic());
if (matcher.matches()) {
final String topic = matcher.replaceFirst(replacement);
+ log.trace("Rerouting from topic '{}' to new topic '{}'",
record.topic(), topic);
Review comment:
Should we gate it with `log.isTraceEnabled()`?
##########
File path:
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/RegexRouter.java
##########
@@ -57,7 +61,10 @@ public R apply(R record) {
final Matcher matcher = regex.matcher(record.topic());
if (matcher.matches()) {
final String topic = matcher.replaceFirst(replacement);
+ log.trace("Rerouting from topic '{}' to new topic '{}'",
record.topic(), topic);
Review comment:
You're right. I misread the line and thought that we were constructing
the string before calling trace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
