[GitHub] [kafka] jolshan commented on a change in pull request #11909: KAFKA-13750: Client Compatability KafkaTest uses invalid idempotency configs

[GitBox]

jolshan commented on a change in pull request #11909:
URL: https://github.com/apache/kafka/pull/11909#discussion_r829541377



##########
File path: 
tools/src/main/java/org/apache/kafka/tools/ClientCompatibilityTest.java
##########
@@ -172,6 +174,13 @@ public static void main(String[] args) throws Exception {
             .dest("describeConfigsSupported")
             .metavar("DESCRIBE_CONFIGS_SUPPORTED")
             .help("Whether describeConfigs is supported in the AdminClient.");
+        parser.addArgument("--idempotent-producer-supported")
+                .action(store())
+                .required(true)
+                .type(Boolean.class)
+                .dest("idempotentProducerSupported")
+                .metavar("IDEMPOTENT_PRODUCER_SUPPORTED")
+                .help("Whether the producer supports idempotency.");

Review comment:
       Ah. How did I miss this 🤦‍♀️
   Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org