idank commented on a change in pull request #11900: URL: https://github.com/apache/kafka/pull/11900#discussion_r831023106
########## File path: clients/src/main/java/org/apache/kafka/server/policy/AlterConfigPolicy.java ########## @@ -71,7 +71,7 @@ public int hashCode() { @Override public boolean equals(Object o) { - if (o == null || o.getClass() != o.getClass()) return false; + if ((o == null) || (!o.getClass().equals(getClass()))) return false; Review comment: `clients/src/main/java/org/apache/kafka/common/protocol/types/RawTaggedField.java` is doing the same thing fwiw. I don't have a strong preference other than I don't have the code checked out and it takes O(hours) to clone the repo. If you're fine either way or want to take this fix yourself, I don't mind. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org