bozhao12 commented on a change in pull request #11942:
URL: https://github.com/apache/kafka/pull/11942#discussion_r834172924



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1028,6 +1028,7 @@ class ReplicaManager(val config: KafkaConfig,
     var bytesReadable: Long = 0
     var errorReadingData = false
     var hasDivergingEpoch = false
+    var notLocalPreferredReadReplica = false

Review comment:
       There is no impact at present. 
   I need to use the replica read capability to do some development, so I added 
a little log to readFromLog() to verify the correctness. I found that every 
time the leader broker selects a non-leader replica, it will trigger the fetch 
response  return with a delay of 500 ms , even though I'm consuming historical 
data. Triggered my log to print, and then traced this case
   I  will make some code modifications and add unit tests according to your 
suggestion.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to