dengziming commented on a change in pull request #11936:
URL: https://github.com/apache/kafka/pull/11936#discussion_r834983243



##########
File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala
##########
@@ -70,7 +70,7 @@ object GetOffsetShell {
                            .withRequiredArg
                            .describedAs("partition ids")
                            .ofType(classOf[String])
-    val timeOpt = parser.accepts("time", "timestamp of the offsets before 
that. [Note: No offset is returned, if the timestamp greater than recently 
committed record timestamp is given.]")
+    val timeOpt = parser.accepts("time", "timestamp of the offsets before 
that. [Note: -1 indicates offset for the specified time is not found]")

Review comment:
       That's a nice catch, -1 may be misunderstood to a time arg, your 
suggestion makes sense to me.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to