cadonna commented on a change in pull request #11923:
URL: https://github.com/apache/kafka/pull/11923#discussion_r835303600



##########
File path: docs/streams/developer-guide/config-streams.html
##########
@@ -677,6 +685,30 @@ <h4><a class="toc-backref" 
href="#id33">default.windowed.value.serde.inner</a><a
               <p>This is discussed in more detail in <a class="reference 
internal" href="datatypes.html#streams-developer-guide-serdes"><span class="std 
std-ref">Data types and serialization</span></a>.</p>
             </div></blockquote>
         </div>
+      <div class="section" id="rack-aware-assignment-tags">
+        <h4><a class="toc-backref" 
href="#id34">rack.aware.assignment.tags</a><a class="headerlink" 
href="#rack-aware-assignment-tags" title="Permalink to this headline"></a>
+        </h4>
+        <blockquote>
+          <div>
+            <p>
+              This configuration sets list of tag keys used to distribute 
standby replicas across Kafka Streams
+              instances. When configured, Kafka Streams will make a 
best-effort to distribute the standby tasks over
+              each client tag dimension.
+            </p>
+            <p>
+              Tags for the Kafka Streams instances can be set via <code 
class="docutils literal"><span class="pre">client.tag.</span></code>
+              prefix. Example:
+            </p>

Review comment:
       I think the doc would benefit from a more complete example. could you 
try to put the example from the KIP in  a concise way here?
   ```
   # Kafka Streams Client 1
   client.tag.zone: eu-central-1a
   client.tag.cluster: k8s-cluster1
   rack.aware.assignment.tags: zone,cluster
    
   # Kafka Streams Client 2
   client.tag.zone: eu-central-1b
   client.tag.cluster: k8s-cluster1
   rack.aware.assignment.tags: zone,cluster
    
   # Kafka Streams Client 3
   client.tag.zone: eu-central-1a
   client.tag.cluster: k8s-cluster2
   rack.aware.assignment.tags: zone,cluster
    
   # Kafka Streams Client 4
   client.tag.zone: eu-central-1b
   client.tag.cluster: k8s-cluster2
   rack.aware.assignment.tags: zone,cluster
   ```
   Maybe it is possible to put the clients next to each other or two client in 
one row and the other two client below. Below the clients you could describe 
who get which standbys for the active tasks on each client.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to