kkonstantine commented on a change in pull request #11908: URL: https://github.com/apache/kafka/pull/11908#discussion_r835564791
########## File path: tests/kafkatest/services/connect.py ########## @@ -279,12 +282,34 @@ def append_to_environment_variable(self, envvar, value): env_opts = "\"%s %s\"" % (env_opts.strip('\"'), value) self.environment[envvar] = env_opts + def append_filestream_connectors_to_classpath(self): Review comment: Given the above and after taking a second look I think I'll keep the current name to avoid any implementation details on the name. Indeed by looking at the code each individual command is an append to the classpath. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org