mjsax commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1079513140


   > Sorry I didn't check the entire implementation before posting
   
   No problem. It's much harder to reverse engineer the code than asking :) 
   
   > But if a key is expired from the inner store (what this PR addresses for 
persistent stores) but is still present in the cache, then do we keep it or 
remove it from the cache? And do we return that key?
   
   For this PR, I would propose to still return the data. It's the exact 
problem that should be fixed in a follow up PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to