showuon commented on a change in pull request #11953:
URL: https://github.com/apache/kafka/pull/11953#discussion_r837088770
##########
File path: core/src/main/scala/kafka/server/AbstractFetcherManager.scala
##########
@@ -32,6 +32,7 @@ abstract class AbstractFetcherManager[T <:
AbstractFetcherThread](val name: Stri
// package private for test
private[server] val fetcherThreadMap = new
mutable.HashMap[BrokerIdAndFetcherId, T]
private val lock = new Object
+ @volatile
private var numFetchersPerBroker = numFetchers
Review comment:
Why should we add `volatile` to `numFetchersPerBroker`? I don't think
it's related to this issue, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
