mumrah commented on a change in pull request #11941:
URL: https://github.com/apache/kafka/pull/11941#discussion_r840670498
##########
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##########
@@ -530,21 +543,38 @@ private ApiError createTopic(CreatableTopic topic,
" time(s): " + e.getMessage());
}
ApiError error = maybeCheckCreateTopicPolicy(() -> {
- Map<String, String> configs = new HashMap<>();
- topic.configs().forEach(config -> configs.put(config.name(),
config.value()));
return new CreateTopicPolicy.RequestMetadata(
- topic.name(), numPartitions, replicationFactor, null,
configs);
+ topic.name(), numPartitions, replicationFactor, null,
creationConfigs);
});
if (error.isFailure()) return error;
}
Uuid topicId = Uuid.randomUuid();
- successes.put(topic.name(), new CreatableTopicResult().
+ CreatableTopicResult result = new CreatableTopicResult().
setName(topic.name()).
setTopicId(topicId).
- setErrorCode((short) 0).
- setErrorMessage(null).
- setNumPartitions(newParts.size()).
- setReplicationFactor((short) newParts.get(0).replicas.length));
+ setErrorCode(NONE.code()).
+ setErrorMessage(null);
+ if (includeConfigs) {
+ Map<String, ConfigEntry> effectiveConfig = configurationControl.
+ computeEffectiveTopicConfigs(creationConfigs);
+ List<String> configNames = new
ArrayList<>(effectiveConfig.keySet());
+ configNames.sort(String::compareTo);
+ for (String configName : configNames) {
+ ConfigEntry entry = effectiveConfig.get(configName);
+ result.configs().add(new
CreateTopicsResponseData.CreatableTopicConfigs().
+ setName(entry.name()).
+ setValue(entry.isSensitive() ? null : entry.value()).
+ setReadOnly(entry.isReadOnly()).
+
setConfigSource(KafkaConfigSchema.translateConfigSource(entry.source()).id()).
+ setIsSensitive(entry.isSensitive()));
+ }
+ result.setNumPartitions(newParts.size());
+ result.setReplicationFactor((short)
newParts.get(0).replicas.length);
Review comment:
Thanks for the explanation. I agree changing this is out of scope for
this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
