showuon commented on code in PR #12007:
URL: https://github.com/apache/kafka/pull/12007#discussion_r844586419
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##########
@@ -617,7 +617,7 @@ public synchronized void
updatePreferredReadReplica(TopicPartition tp, int prefe
* Unset the preferred read replica. This causes the fetcher to go back to
the leader for fetches.
*
* @param tp The topic partition
- * @return true if the preferred read replica was set, false otherwise.
+ * @return return the removed preferred read replica was set, None
otherwise.
Review Comment:
we have 2 `return` now. How about:
`@return the removed preferred read replica if set, None otherwise.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
