ijuma commented on PR #12017: URL: https://github.com/apache/kafka/pull/12017#issuecomment-1092939875
Thanks for the PR. In my opinion, we should set the field to ignorable and add a comment where we set the error code stating that it's ignored for versions older than 3. The generator code basically does what we are doing manually right now. And I don't see much value in logging when this expected case happens. If we ever add more error codes in the future, we can then figure out if we need to do more. It's unclear at the moment if that will be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
