ccding commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r847548177


##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -678,7 +678,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
    *
    * @throws KafkaStorageException if rename fails
    */
-  def renameDir(name: String): Unit = {
+  def renameDir(name: String, reinitialize: Boolean): Unit = {

Review Comment:
   can we write some comments to describe what `reinitialize` means and in what 
case it should be set to true/false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to