mjsax commented on code in PR #12037:
URL: https://github.com/apache/kafka/pull/12037#discussion_r849975933
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java:
##########
@@ -48,15 +51,25 @@
private final Windows<W> windows;
private final Initializer<VAgg> initializer;
private final Aggregator<? super KIn, ? super VIn, VAgg> aggregator;
+ private final boolean emitFinal;
private boolean sendOldValues = false;
public KStreamWindowAggregate(final Windows<W> windows,
final String storeName,
final Initializer<VAgg> initializer,
final Aggregator<? super KIn, ? super VIn,
VAgg> aggregator) {
+ this(windows, storeName, false, initializer, aggregator);
+ }
+
+ public KStreamWindowAggregate(final Windows<W> windows,
Review Comment:
The PR title says "sliding window" but this it the "time window" class (ie,
hopping/tumbling).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
