ijuma commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r850033183
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -187,7 +187,7 @@ private static class TopicPartitionEntry {
private static final Comparator<ProducerBatch>
PRODUCER_BATCH_COMPARATOR = (b1, b2) -> {
if (b1.baseSequence() < b2.baseSequence()) return -1;
else if (b1.baseSequence() > b2.baseSequence()) return 1;
- else return b1.equals(b2) ? 0 : 1;
+ else return Integer.compare(b1.hashCode(), b2.hashCode());
Review Comment:
I replied to the original discussion clarifying that some of the assumptions
there are incorrect. We should not return `true` for the case where `hashCode`
is true and `equal` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
