RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEngineFactoryClassDoc)
/** ********* Sasl Configuration ****************/
- .define(SaslMechanismInterBrokerProtocolProp, STRING,
Defaults.SaslMechanismInterBrokerProtocol, MEDIUM,
SaslMechanismInterBrokerProtocolDoc)
+ .define(SaslMechanismInterBrokerProtocolProp, STRING,
Defaults.SaslMechanismInterBrokerProtocol, ConfigDef.CompositeValidator.of(new
ConfigDef.NonNullValidator(), new ConfigDef.NonEmptyString()), MEDIUM,
SaslMechanismInterBrokerProtocolDoc)
.define(SaslJaasConfigProp, PASSWORD, null, MEDIUM, SaslJaasConfigDoc)
- .define(SaslEnabledMechanismsProp, LIST, Defaults.SaslEnabledMechanisms,
MEDIUM, SaslEnabledMechanismsDoc)
+ .define(SaslEnabledMechanismsProp, LIST, Defaults.SaslEnabledMechanisms,
new BrokerSecurityConfigs.SaslEnabledMechanismsValidator(), MEDIUM,
SaslEnabledMechanismsDoc)
Review Comment:
Why do we need to set `sasl.enabled.mechanisms` to `,,,` if SASL is not
enabled. Instead of removing `sasl.enabled.mechanisms` configuration.
In fact, when SASL is not enabled, configuring various mechanisms in
`sasl.enabled.mechanisms` will not affect the startup of the broker. I can
promise this.
eg:
`sasl.enabled.mechanisms=GSSAPI,PLAIN,SCRAM-SHA-256,SCRAM-SHA-512`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
