showuon commented on code in PR #12000:
URL: https://github.com/apache/kafka/pull/12000#discussion_r852563712
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -182,6 +182,17 @@ public class CommonClientConfigs {
public static final String DEFAULT_API_TIMEOUT_MS_DOC = "Specifies the
timeout (in milliseconds) for client APIs. " +
"This configuration is used as the default timeout for all client
operations that do not specify a <code>timeout</code> parameter.";
+ /**
+ * <code>internal.leave.group.on.close</code>
+ * Whether or not the consumer should leave the group on close. If set to
<code>false</code> then a rebalance
+ * won't occur until <code>session.timeout.ms</code> expires.
+ *
+ * <p>
+ * Note: this is an internal configuration and could be changed in the
future in a backward incompatible way
+ *
+ */
+ public static final String LEAVE_GROUP_ON_CLOSE_CONFIG =
"internal.leave.group.on.close";
Review Comment:
OK, I see. Then we can just leave the `GroupRebalanceConfig` as is, and
change other places. The main reason is the config
`LEAVE_GROUP_ON_CLOSE_CONFIG` is only used in Consumer, not other places, so we
should keep it there. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
