mimaison commented on code in PR #12004:
URL: https://github.com/apache/kafka/pull/12004#discussion_r853285333
##########
core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala:
##########
@@ -413,7 +413,7 @@ class LogCleanerManagerTest extends Logging {
// updateCheckpoints should remove the topicPartition data in the logDir
cleanerManager.updateCheckpoints(logDir, partitionToRemove =
Option(topicPartition))
-
assertTrue(cleanerManager.allCleanerCheckpoints.get(topicPartition).isEmpty)
+ assertTrue(!cleanerManager.allCleanerCheckpoints.contains(topicPartition))
Review Comment:
Would
`assertFalse(cleanerManager.allCleanerCheckpoints.contains(topicPartition))` be
even more readable?
##########
core/src/test/scala/unit/kafka/log/LogCleanerManagerTest.scala:
##########
@@ -710,14 +710,16 @@ class LogCleanerManagerTest extends Logging {
assertThrows(classOf[IllegalStateException], () =>
cleanerManager.doneCleaning(topicPartition, log.dir, 1))
cleanerManager.setCleaningState(topicPartition, LogCleaningInProgress)
- cleanerManager.doneCleaning(topicPartition, log.dir, 1)
+ val endOffset = 1L
+ cleanerManager.doneCleaning(topicPartition, log.dir, endOffset)
assertTrue(cleanerManager.cleaningState(topicPartition).isEmpty)
-
assertTrue(cleanerManager.allCleanerCheckpoints.get(topicPartition).nonEmpty)
+ assertTrue(cleanerManager.allCleanerCheckpoints.contains(topicPartition))
+ assertEquals(Some(endOffset),
cleanerManager.allCleanerCheckpoints.get(topicPartition))
cleanerManager.setCleaningState(topicPartition, LogCleaningAborted)
cleanerManager.doneCleaning(topicPartition, log.dir, 1)
Review Comment:
Should we reuse `endOffsets` here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
