showuon commented on PR #12069: URL: https://github.com/apache/kafka/pull/12069#issuecomment-1104771858
@RivenSun2 , thanks for the contributions! One little suggestion to you. I've noticed that each time, your PR will include all the unrelated commits. (ref: https://github.com/apache/kafka/pull/12069/commits) It doesn't affect the result, though, I think it is better to learn to make the commit history clear. tip: you should always fork out another branch based on the latest trunk branch and then start the code change. FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
