hachikuji commented on code in PR #12071:
URL: https://github.com/apache/kafka/pull/12071#discussion_r855451915
##########
clients/src/main/resources/common/message/LeaderAndIsrRequest.json:
##########
@@ -78,8 +78,8 @@
"about": "The leader epoch." },
{ "name": "Isr", "type": "[]int32", "versions": "0+", "entityType":
"brokerId",
"about": "The in-sync replica IDs." },
- { "name": "ZkVersion", "type": "int32", "versions": "0+",
- "about": "The ZooKeeper version." },
+ { "name": "PartitionEpoch", "type": "int32", "versions": "0+",
+ "about": "The current epoch for the partition for KRaft controllers.
The current ZK version for the legacy controllers." },
Review Comment:
Maybe something like this:
```
The current epoch for the partition. The epoch is a monotonically increasing
value which is incremented after every partition change. (Since the
LeaderAndIsr request is only used by the legacy controller, this corresponds to
the zkVersion)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
