divijvaidya commented on code in PR #12077:
URL: https://github.com/apache/kafka/pull/12077#discussion_r856952156
##########
clients/src/main/java/org/apache/kafka/clients/consumer/OffsetResetStrategy.java:
##########
@@ -16,6 +16,13 @@
*/
package org.apache.kafka.clients.consumer;
+import java.util.Locale;
+
public enum OffsetResetStrategy {
- LATEST, EARLIEST, NONE
+ LATEST, EARLIEST, NONE;
+
+ @Override
+ public String toString() {
+ return super.toString().toLowerCase(Locale.ROOT);
Review Comment:
I am wondering if this could have an impact when using non-english locale,
e.g. there may be places in the code which perform a comparison of the enum
with string "latest" but in a different locale this comparison may fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
