YeonCheolGit commented on code in PR #12019:
URL: https://github.com/apache/kafka/pull/12019#discussion_r862394876
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java:
##########
@@ -151,19 +159,46 @@ private Long ensureLeaderConfig(long maxOffset,
WorkerCoordinator coordinator) {
* @param coordinator the worker coordinator instance that provide the
configuration snapshot
* and get assigned the leader state during this assignment
* @param protocolVersion the Connect subprotocol version
- * @return the serialized assignment of tasks to the whole group,
including assigned or
- * revoked tasks
+ * @return the assignment of tasks to the whole group, including assigned
or revoked tasks
*/
- protected Map<String, ByteBuffer> performTaskAssignment(String leaderId,
long maxOffset,
+ private Map<String, ExtendedAssignment> performTaskAssignment(String
leaderId, long maxOffset,
Review Comment:
Just wondering that why changing `protected` to `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
