junrao commented on code in PR #12005:
URL: https://github.com/apache/kafka/pull/12005#discussion_r866357178
##########
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##########
@@ -51,6 +51,7 @@ import scala.math._
*/
abstract class AbstractFetcherThread(name: String,
clientId: String,
+ val leader: LeaderEndPoint,
Review Comment:
Yes, we need to pass brokerEndPoint to LocalLeaderEndPoint. Intuitively, it
seems that it makes sense for LeaderEndPoint to own brokerEndPoint instead of
passing in two endpoints around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
