ijuma commented on PR #12131: URL: https://github.com/apache/kafka/pull/12131#issuecomment-1123802358
Thanks for the explanation. It's interesting how these underlying primitives end up not working as intended. In any case, the fix in this PR seems fine, but we didn't add any documentation. Can we explain that we consider a connection as "connected" for reconnect purposes after the api versions request succeeds? > Another case is if there are clients that use NetworkClient and don't implement retry backoff, then retry backoff has no effect. Quick note regarding this. All clients using `NetworkClient` should implement a retry backoff. Also `NetworkClient` is an internal class and not meant to be used by external users (no compatibility guarantees are provided, etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
