mimaison commented on code in PR #11748:
URL: https://github.com/apache/kafka/pull/11748#discussion_r873606546
##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java:
##########
@@ -319,27 +319,21 @@ public void testReplication() throws Exception {
waitForCondition(() ->
primaryClient.remoteConsumerOffsets(consumerGroupName, BACKUP_CLUSTER_ALIAS,
Duration.ofMillis(CHECKPOINT_DURATION_MS)).containsKey(new
TopicPartition("backup.test-topic-1", 0)), CHECKPOINT_DURATION_MS, "Offsets not
translated downstream to primary cluster.");
- waitForCondition(() ->
primaryClient.remoteConsumerOffsets(consumerGroupName, BACKUP_CLUSTER_ALIAS,
- Duration.ofMillis(CHECKPOINT_DURATION_MS)).containsKey(new
TopicPartition("test-topic-1", 0)), CHECKPOINT_DURATION_MS, "Offsets not
translated upstream to primary cluster.");
Review Comment:
For this types of changes, a diagram often helps.
We see that `mm2-offset-syncs.primary.internal` only contains mapping from
`test-topic-1` on the backup cluster to `backup.test-topic-1` on the primary
cluster. Then when backup->primary checkpoint runs it's only able to compute
committed offsets for `backup.test-topic-1`, it has no information about
offsets for the local `test-topic-1` in the primary cluster.
<img width="1230" alt="image"
src="https://user-images.githubusercontent.com/903615/168580961-8f3e5860-cae3-43bf-9d36-ecd7553e42eb.png";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
![https://user-images.githubusercontent.com/903615/168580961-8f3e5860-cae3-43bf-9d36-ecd7553e42eb.png"](https://user-images.githubusercontent.com/903615/168580961-8f3e5860-cae3-43bf-9d36-ecd7553e42eb.png"){kind=link}