C0urante commented on code in PR #11780:
URL: https://github.com/apache/kafka/pull/11780#discussion_r874759802
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -271,8 +278,10 @@ void doShutdown() {
state = State.FAILED;
statusListener.onFailure(connName, t);
} finally {
- ctx.close();
- metrics.close();
+ Utils.closeQuietly(ctx, "Connector context for " + connName);
+ Utils.closeQuietly(metrics, "Connector metrics for " + connName);
+ Utils.closeQuietly(offsetStorageReader, "Offset reader for " +
connName);
+ Utils.closeQuietly(offsetStore::stop, "offset backing store for "
+ connName);
Review Comment:
Good point; given that `Utils::closeQuietly` uses the second parameter in
the middle of a [log
message](https://github.com/apache/kafka/blob/07459d2eb3e6c2278f22021854ae79c11cf6129b/clients/src/main/java/org/apache/kafka/common/utils/Utils.java#L1007)
I'm inclined to lowercase each of these.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
