hachikuji commented on code in PR #12150:
URL: https://github.com/apache/kafka/pull/12150#discussion_r875249781
##########
core/src/test/scala/unit/kafka/cluster/PartitionTest.scala:
##########
@@ -439,18 +545,33 @@ class PartitionTest extends AbstractPartitionTest {
val leaderEpoch = 5
val partition = setupPartitionWithMocks(leaderEpoch, isLeader = false)
- def assertReadRecordsError(error: Errors,
- currentLeaderEpochOpt: Optional[Integer],
- fetchOnlyLeader: Boolean): Unit = {
+ def assertReadRecordsError(
Review Comment:
I do agree there is some redundancy. I tried to simplify the tests a bit by
using the fetcher helpers and `assertThrows`, but I couldn't come up with a
really clean way to consolidate them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
