[GitHub] [kafka] dajac commented on a diff in pull request #12187: KAFKA-13858; Kraft should not shutdown metadata listener until controller shutdown is finished

[GitBox]

dajac commented on code in PR #12187:
URL: https://github.com/apache/kafka/pull/12187#discussion_r880194784


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2141,23 +2141,22 @@ class ReplicaManager(val config: KafkaConfig,
             stateChangeLogger.trace(s"Unable to start fetching $tp with topic 
" +
               s"ID ${info.topicId} because the replica manager is shutting 
down.")
           } else {
-            if (isInControlledShutdown && 
!info.partition.isr.contains(config.brokerId)) {
-              // If we are in controlled shutdown and the replica is not in 
the ISR,
-              // we stop the replica.
+            // We always update the follower state.

Review Comment:
   Yeah. That seems to be the right thing to do. I have looked at the 
dependencies on that state and I haven't identified any issues so far.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org