tombentley commented on code in PR #12179:
URL: https://github.com/apache/kafka/pull/12179#discussion_r881527740
##########
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslServerAuthenticator.java:
##########
@@ -681,8 +681,8 @@ else if (connectionsMaxReauthMs == null)
else
retvalSessionLifetimeMs = zeroIfNegative(
Math.min(credentialExpirationMs -
authenticationEndMs, connectionsMaxReauthMs));
- if (retvalSessionLifetimeMs > 0L)
- sessionExpirationTimeNanos = authenticationEndNanos + 1000
* 1000 * retvalSessionLifetimeMs;
+
+ sessionExpirationTimeNanos = authenticationEndNanos + 1000 *
1000 * retvalSessionLifetimeMs;
Review Comment:
Probably worth a comment explaining that `sessionExpirationTimeNanos` should
always be set to a non-null value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
