mumrah commented on PR #12182: URL: https://github.com/apache/kafka/pull/12182#issuecomment-1137837836
@jsancio I had a Supplier originally, but wanted to have the ability to get the metadata.version at a particular epoch. I think we will need this when we do snapshots before upgrades. Colin's suggestion to just use FeatureControlManager solves that too. @cmccabe 1) Sounds good, we can mark 3.2-IV0 as didMetadataChange=true. As discussed offline, we won't bump the record version for the records changed on that version since we used tagged fields. That does mean our downgrade logic will need some explicit check on the target version and know to omit those tagged fields. 2) So just include a final `MetadataVersion` in each *Image class? Seems reasonable 👌 3) Yea I think should work for the most part. If we end up exposing the MetadataVersion outside of QuorumController (like into ControllerApis or perhaps into the Raft classes) we may want an abstraction to avoid the FeatureControlManager class leaking out. I've opened #12214 which I'd like to do prior to this PR. It cleans up some feature flag code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
