cmccabe commented on PR #12216: URL: https://github.com/apache/kafka/pull/12216#issuecomment-1142595196
> How about extending all our tests with "AbstractKafkaUnitTest" (or something similar) and adding this timeout rule over there? I can see other use cases where such a base class would be helpful such as adding info level log messages before/after each test etc. Similarly adding it to IntegrationTestHarness for integration tests in the core code? Test inheritance is an anti-pattern because it tightly couples the implementation of many unrelated things. We see this a lot .. changing one method in `QuorumTestHarness` can lead to chaos since many things inherit from it. We certainly would not want to have to change the inheritance hierachy to set a different timeout, for example. > Another suggestion: We can potentially use @Timeout directly annotated on the class just like we do in QuorumControllerTest We cannot use `@Timeout` because streams is still using an older version of JUnit that does not support it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
