dengziming opened a new pull request, #12234: URL: https://github.com/apache/kafka/pull/12234
*More detailed description of your change* I find many error logs when running tests, here is one of them: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-12232/1/testReport/kafka.server/KRaftClusterTest/Build___JDK_8_and_Scala_2_12___testUnregisterBroker__/ ``` [2022-05-31 15:56:28,190] ERROR [Controller 3000] Error replaying record FeatureLevelRecord(name='metadata.version', featureLevel=5) at last offset 0. (org.apache.kafka.controller.QuorumController:1188) java.lang.RuntimeException: Controller cannot support feature metadata.version at version 5 at org.apache.kafka.controller.FeatureControlManager.replay(FeatureControlManager.java:269) at org.apache.kafka.controller.QuorumController.replay(QuorumController.java:1166) at org.apache.kafka.control ...[truncated 844207 chars]... ``` this is because we just return empty supported features in Controller ApiVersionResponse, so the `quorumSupportedFeature` will always return empty: https://github.com/apache/kafka/blob/4c9eeef5b2dff9a4f0977fbc5ac7eaaf930d0d0e/metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java#L89-L94 *Summary of testing strategy (including rationale)* After this change, these error logs disappeared. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
