Looks good, but I notice that all-non-failing-tests.h has a comment referring to the -O2 in this file, so that should also be updated to something like:
/* test-cold-attribute.c: This can't be in the testcases array as it needs a specific optimization flag. */ or similar. OK with that change. -- https://forge.sourceware.org/gcc/gcc-TEST/pulls/129#issuecomment-4493
