Author: bklaas
Date: Tue Feb 12 13:51:16 2008
New Revision: 1919

URL: http://svn.slimdevices.com?rev=1919&root=Jive&view=rev
Log:
Bug: 6667
Description: patch from Richard that properly keeps track of players table
so Choose Player menu item is managed correctly

Modified:
    branches/7.0/jive/src/pkg/jive/share/jive/slim/Player.lua
    branches/7.0/jive/src/pkg/jive/share/jive/slim/SlimServer.lua

Modified: branches/7.0/jive/src/pkg/jive/share/jive/slim/Player.lua
URL: 
http://svn.slimdevices.com/branches/7.0/jive/src/pkg/jive/share/jive/slim/Player.lua?rev=1919&root=Jive&r1=1918&r2=1919&view=diff
==============================================================================
--- branches/7.0/jive/src/pkg/jive/share/jive/slim/Player.lua (original)
+++ branches/7.0/jive/src/pkg/jive/share/jive/slim/Player.lua Tue Feb 12 
13:51:16 2008
@@ -141,9 +141,10 @@
 local function _setPlayerPower(self, power)
        log:debug("_setPlayerPower")
 
+       power = tonumber(power)
        if power != self.power then
-               self.power = tonumber(power)
-               self.jnt:notify('playerPower', self, tonumber(power))
+               self.power = power
+               self.jnt:notify('playerPower', self, power)
        end
 end
 
@@ -255,7 +256,7 @@
 
        -- notify of new player
        log:info(obj, " new for ", obj.slimServer)
-       jnt:notify('playerNew', obj)
+       obj.slimServer:_addPlayer(obj)
 
        return obj
 end
@@ -280,13 +281,13 @@
        if self.slimServer ~= slimServer then
                -- delete from old server
                if self.slimServer then
-                       self.slimServer:_deletePlayer(self)
+                       self:free(self.slimServer)
                end
 
                -- add to new server
                self.slimServer = slimServer
+               self.slimServer:_addPlayer(self)
                log:info(self, " new for ", self.slimServer)
-               self.jnt:notify('playerNew', self)
        end
        
        self.model = playerInfo.model
@@ -429,7 +430,7 @@
        end
 
        log:info(self, " delete for ", self.slimServer)
-       self.jnt:notify('playerDelete', self)
+       self.slimServer:_deletePlayer(self)
        self:offStage()
        self.slimServer = nil
 

Modified: branches/7.0/jive/src/pkg/jive/share/jive/slim/SlimServer.lua
URL: 
http://svn.slimdevices.com/branches/7.0/jive/src/pkg/jive/share/jive/slim/SlimServer.lua?rev=1919&root=Jive&r1=1918&r2=1919&view=diff
==============================================================================
--- branches/7.0/jive/src/pkg/jive/share/jive/slim/SlimServer.lua (original)
+++ branches/7.0/jive/src/pkg/jive/share/jive/slim/SlimServer.lua Tue Feb 12 
13:51:16 2008
@@ -157,8 +157,6 @@
                        
                                player = Player(self.jnt, self, player_info)
                        
-                               self.players[player_info.playerid] = player
-
                        else
                                -- update existing players
                                self.players[player_info.playerid]:update(self, 
player_info)
@@ -180,8 +178,14 @@
 
 -- package private method to delete a player
 function _deletePlayer(self, player)
-       player:free(self)
-       table:delete(self.players, player:getId())
+       self.players[player:getId()] = nil
+       self.jnt:notify('playerDelete', player)
+end
+
+
+function _addPlayer(self, player)
+       self.players[player:getId()] = player
+       self.jnt:notify('playerNew', player)
 end
 
 

_______________________________________________
Jive-checkins mailing list
[email protected]
http://lists.slimdevices.com/cgi-bin/mailman/listinfo/jive-checkins

Reply via email to