Author: titmuss
Date: Wed Feb 13 15:47:59 2008
New Revision: 1945

URL: http://svn.slimdevices.com?rev=1945&root=Jive&view=rev
Log:
Bug: 7117
Description:
Multiple instances of the SqueezeboxJive applet could be created when using 
some 
settings windows. This caused power management problems, including the sound 
effects 
being turned off.

Modified:
    
branches/7.0/jive/src/pkg/jive_squeezeboxjive/share/applets/SqueezeboxJive/SqueezeboxJiveApplet.lua

Modified: 
branches/7.0/jive/src/pkg/jive_squeezeboxjive/share/applets/SqueezeboxJive/SqueezeboxJiveApplet.lua
URL: 
http://svn.slimdevices.com/branches/7.0/jive/src/pkg/jive_squeezeboxjive/share/applets/SqueezeboxJive/SqueezeboxJiveApplet.lua?rev=1945&root=Jive&r1=1944&r2=1945&view=diff
==============================================================================
--- 
branches/7.0/jive/src/pkg/jive_squeezeboxjive/share/applets/SqueezeboxJive/SqueezeboxJiveApplet.lua
 (original)
+++ 
branches/7.0/jive/src/pkg/jive_squeezeboxjive/share/applets/SqueezeboxJive/SqueezeboxJiveApplet.lua
 Wed Feb 13 15:47:59 2008
@@ -429,7 +429,7 @@
                end
        )
 
-       self:tieAndShowWindow(window)
+       window:show()
        return window
 end
 
@@ -488,7 +488,7 @@
                end
        )
 
-       self:tieAndShowWindow(window)
+       window:show()
        return window
 end
 
@@ -519,7 +519,7 @@
                -- e.g. Bug 6641 during a firmware upgrade
                -- XXXX this needs reviewing
                local topWindow = Framework.windowStack[1]
-               if oo.instanceof(topWindow, Popup) then
+               if oo.instanceof(topWindow, Popup) and not self.lockedPopup then
                        self:setPowerState("dimmed")
                        
                elseif self.powerState == "dimmed" then
@@ -644,9 +644,8 @@
        popup:addWidget(Icon("iconLocked"))
        popup:addWidget(Label("text", self:string("BSP_SCREEN_LOCKED")))
        popup:addWidget(Textarea("help", self:string("BSP_SCREEN_LOCKED_HELP")))
-       self:tieAndShowWindow(popup)
-
-       self:setPowerState("locked")
+
+       popup:show()
 
        self.lockedPopup = popup
        self.lockedTimer = Timer(2000,
@@ -655,6 +654,8 @@
                                         self:_setCPUSpeed(false)
                                 end,
                                 true)
+
+       self:setPowerState("locked")
 
        self.lockedListener = 
                Framework:addListener(EVENT_KEY_DOWN | EVENT_KEY_PRESS,
@@ -728,7 +729,7 @@
        -- make sure the display is on
        self:setBrightness()
 
-       self:tieAndShowWindow(popup)
+       popup:show()
 end
 
 
@@ -767,7 +768,7 @@
        }
        menu:setItems(items)
 
-        self:tieAndShowWindow(window)
+       window:show()
         return window
 end
 
@@ -801,7 +802,7 @@
                true
        )
 
-       self:tieAndShowWindow(popup)
+       popup:show()
 
        popup:playSound("SHUTDOWN")
 end
@@ -887,7 +888,7 @@
                end
        )
 
-       self:tieAndShowWindow(window)
+       window:show()
        return window
 end
 

_______________________________________________
Jive-checkins mailing list
[email protected]
http://lists.slimdevices.com/cgi-bin/mailman/listinfo/jive-checkins

Reply via email to