Mike Stover wrote:
No, one factory to create all of them. In fact it is just Class.forName(elementClassName).newInstance(). Filling the properties with default values should not be done by the GUI but in the element's constructor. So the only property the test element constructor can not set is the gui class name. But the test element should not know about GUIs anyway so I don't see the need to hold the name of the corresponding GUI class in the test element's properties. There are other ways to assign GUIs to test elements (e.g. ask the GUI which kind of test elements it can handle and then select the right one) and to keep separation of concerns. The test elements are the model and should not know about the very existence of a GUI.On 3 Feb 2003 at 23:26, Oliver Rossmueller wrote:Mike Stover wrote:Ok folks, 1.8.1 is out of the way (I'll be making a src release file too, later). I've just committed my changes to make the test tree hold TestElement objects instead of GUI objects.Mike,
It was both easier and harder than I thought it would be originally. Please check it out and put it through it's paces. I think I touched all the important points, but we need to be sure. One thing though, it is much faster loading big test plans :-)
I walked through your changes and I guess you touched all the important points. Although, there is one fact that I don't like in the current solution: the GUI components are test element factories. I would like to separate these two concerns, the responsibility of the GUI components should be to edit/modify the test elements but not to create them.
But since the GUI objects have to know all about the TestElements anyway, why shouldn't they serve as factories for their creation? Otherwise, we need a new class for every TestElement just to create them?
Oliver
Oliver-- Michael Stover [EMAIL PROTECTED] Yahoo IM: mstover_ya ICQ: 152975688 AIM: mstover777 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]-- Michael Stover [EMAIL PROTECTED] Yahoo IM: mstover_ya ICQ: 152975688 AIM: mstover777 --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
smime.p7s
Description: S/MIME Cryptographic Signature
