I don't have a strong opinion about this, although personally I like Log4J. However, my general opinion is that using Commons Logging is great for library code, since this makes it possible to use the same logging setup for several libraries used by one application. But when working with a particular application, there doesn't seem to be a lot of benefit in being able to use multiple different logging systems -- it doesn't have to interoperate, so as long as it has the basic functionality, then the exact logging system in use doesn't matter much.
So I don't see a big need to switch to Commons Logging for JMeter. But I could be convinced otherwise.
For making changes to the call to getLoggerFor( ) for all of the classes, it might be easier for one of the committers to do this directly, rather than dealing with patches. I would be willing to do this part of it if you'd like...although it may take me a few days to get through it....my wife and I just had a baby about a week ago (pictures up at http://xirr.com/~jeremy_a/family/kajsa.html), and we have family here and things.
Jeremy
BAZLEY, Sebastian wrote:
Yes, thanks, agreed - that would simplify/rationalise the logging using Avalon logkit.
But it would not allow the use of LOG4J or Java 1.4 logging without edit/recompile, AFAIK. For most source files, the changes to convert to Commons Logging would be very similar to those needed to tidy up the logging categories, which is why I thought it might be useful to consider.
But I am happy to stick with LogKit if everyone else is. [One could always do the Commons Logging change later - it would be simple using Eclipse!]
I would like to be able to change the logging level without having to edit the properties file. I can contribute a patch to add a command line option to do this (calling the LoggingManager method).
I'll try and get some patches out this weekend.
The changes to getLoggerFor() could be done as one or more patch files -
which is easiest for the commiters? One giant patch, one per file, or perhaps one per functional area (core,
protocol etc)?
By the way, LoggingManager seems to be in jorphan.jar, which strikes me as a
bit odd.
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
