sebb        2003/10/19 15:39:03

  Modified:    src/jorphan/org/apache/jorphan/util JOrphanUtils.java
               src/jorphan/org/apache/jorphan/collections HashTree.java
                        Data.java
               src/jorphan/org/apache/jorphan/reflect ClassFinder.java
  Log:
  Unused fields; replace new String(s) by s,; fix null compares; javadoc tags
  
  Revision  Changes    Path
  1.5       +2 -2      
jakarta-jmeter/src/jorphan/org/apache/jorphan/util/JOrphanUtils.java
  
  Index: JOrphanUtils.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/jorphan/org/apache/jorphan/util/JOrphanUtils.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- JOrphanUtils.java 5 Oct 2003 00:48:36 -0000       1.4
  +++ JOrphanUtils.java 19 Oct 2003 22:39:03 -0000      1.5
  @@ -60,8 +60,8 @@
    * This class contains frequently-used static utility methods.
    *
    * @author     <a href="mailto://[EMAIL PROTECTED]">Jordi Salvat i Alabart</a>
  - * @created    27th December 2002
  - * @version    $Revision$
  + * Created    27th December 2002
  + * @version    $Revision$ Last updated: $Date$
    */
   public final class JOrphanUtils
   {
  
  
  
  1.9       +2 -2      
jakarta-jmeter/src/jorphan/org/apache/jorphan/collections/HashTree.java
  
  Index: HashTree.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/jorphan/org/apache/jorphan/collections/HashTree.java,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- HashTree.java     7 Oct 2003 18:27:10 -0000       1.8
  +++ HashTree.java     19 Oct 2003 22:39:03 -0000      1.9
  @@ -1108,7 +1108,7 @@
                   Arrays.asList(new String[] { "1", "2", "3", "4" });
               HashTree tree = new HashTree();
               log.debug("treePath = " + treePath);
  -            tree.add(treePath, new String("value"));
  +            tree.add(treePath, "value");
               log.debug("Now treePath = " + treePath);
               log.debug(tree.toString());
               assertEquals(1, tree.list(treePath).size());
  
  
  
  1.7       +2 -2      
jakarta-jmeter/src/jorphan/org/apache/jorphan/collections/Data.java
  
  Index: Data.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/jorphan/org/apache/jorphan/collections/Data.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- Data.java 5 Oct 2003 00:48:37 -0000       1.6
  +++ Data.java 19 Oct 2003 22:39:03 -0000      1.7
  @@ -78,7 +78,7 @@
   {
       private static Logger log = LoggingManager.getLoggerForClass();
       Map data;
  -    Map iterators = new HashMap();
  +    //Map iterators = new HashMap();
       // Hashtable dataLine;
       ArrayList header;
       // saves current position in data Vector
  
  
  
  1.7       +3 -7      
jakarta-jmeter/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java
  
  Index: ClassFinder.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/jorphan/org/apache/jorphan/reflect/ClassFinder.java,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- ClassFinder.java  5 Oct 2003 00:48:36 -0000       1.6
  +++ ClassFinder.java  19 Oct 2003 22:39:03 -0000      1.7
  @@ -262,7 +262,8 @@
       }
       private static String fixDotDir(String path)
       {
  -        if (path != null && path.equals("."))
  +     if (path == null) return null;
  +        if (path.equals("."))
           {
               return System.getProperty("user.dir");
           }
  @@ -490,11 +491,6 @@
                   // might throw an exception, assume this is ignorable
                   try
                   {
  -                    // Class.forName() doesn't like nulls
  -                    if (strClassName == null)
  -                    {
  -                        continue;
  -                    }
                       c =
                           Class.forName(
                               strClassName,
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to