sebb 2003/10/20 16:57:24
Modified: src/core/org/apache/jmeter/threads/gui ThreadGroupGui.java
src/core/org/apache/jmeter/util JMeterUtils.java
src/core/org/apache/jmeter/samplers SampleResult.java
Sampler.java
src/core/org/apache/jmeter/gui/action AddToTree.java
src/core/org/apache/jmeter/engine ClientJMeterEngine.java
src/core/org/apache/jmeter/gui/util
TextAreaTableCellEditor.java
src/core/org/apache/jmeter/threads
ReflectionThreadGroup.java JMeterThread.java
src/core/org/apache/jmeter/testelement/property
NullProperty.java
src/core/org/apache/jmeter/gui
AbstractJMeterGuiComponent.java
src/core/org/apache/jmeter/visualizers/gui
AbstractVisualizer.java
src/core/org/apache/jmeter/reporters FileReporter.java
Log:
Fixing Javadoc warnings; some unused fields commented
Revision Changes Path
1.21 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/threads/gui/ThreadGroupGui.java
Index: ThreadGroupGui.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/threads/gui/ThreadGroupGui.java,v
retrieving revision 1.20
retrieving revision 1.21
diff -u -r1.20 -r1.21
--- ThreadGroupGui.java 5 Oct 2003 22:21:23 -0000 1.20
+++ ThreadGroupGui.java 20 Oct 2003 23:57:24 -0000 1.21
@@ -136,7 +136,7 @@
/**
* Modifies a given TestElement to mirror the data in the gui components.
- * @see JMeterGUIComponent#modifyTestElement(TestElement)
+ * @see org.apache.jmeter.gui.JMeterGUIComponent#modifyTestElement(TestElement)
*/
public void modifyTestElement(TestElement tg)
{
1.50 +5 -4 jakarta-jmeter/src/core/org/apache/jmeter/util/JMeterUtils.java
Index: JMeterUtils.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/util/JMeterUtils.java,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- JMeterUtils.java 19 Oct 2003 22:35:16 -0000 1.49
+++ JMeterUtils.java 20 Oct 2003 23:57:24 -0000 1.50
@@ -422,6 +422,7 @@
[EMAIL PROTECTED] properties The properties with information about the
samplers
[EMAIL PROTECTED] The Controllers value
*/
+ //TODO - does not appear to be called directly
public static Vector getControllers(Properties properties)
{
String name = "controller.";
@@ -687,12 +688,12 @@
{
if (className != null)
{
- className.trim();
+ className.trim();//TODO does nothing - presumably should be
s=className.trim()
}
if (impls != null)
{ // FIXME: Shouldn't this be impls.trim()?
- className.trim();
+ className.trim();//TODO does nothing!!
}
try
@@ -1046,7 +1047,7 @@
public static final String PROPERTIES = "jmeter.elements.properties";
/**
* Gets the JMeter Version.
- * @returns the JMeter version.
+ * @return the JMeter version string
*/
public static String getJMeterVersion()
{
1.13 +3 -3
jakarta-jmeter/src/core/org/apache/jmeter/samplers/SampleResult.java
Index: SampleResult.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/samplers/SampleResult.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- SampleResult.java 5 Oct 2003 00:10:33 -0000 1.12
+++ SampleResult.java 20 Oct 2003 23:57:24 -0000 1.13
@@ -349,7 +349,7 @@
this.dataEncoding = dataEncoding;
}
/**
- * @return
+ * @return whether to stop the test
*/
public boolean isStopTest()
{
@@ -357,7 +357,7 @@
}
/**
- * @return
+ * @return whether to stop this thread
*/
public boolean isStopThread()
{
1.4 +2 -2 jakarta-jmeter/src/core/org/apache/jmeter/samplers/Sampler.java
Index: Sampler.java
===================================================================
RCS file: /home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/samplers/Sampler.java,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- Sampler.java 19 Oct 2003 22:27:49 -0000 1.3
+++ Sampler.java 20 Oct 2003 23:57:24 -0000 1.4
@@ -60,7 +60,7 @@
* Classes which are able to generate information about an entry should
* implement this interface.
*
- * @author
+ * @author unattributed
* @version $Revision$ Last updated: $Date$
*/
public interface Sampler extends java.io.Serializable, TestElement
1.11 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/gui/action/AddToTree.java
Index: AddToTree.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/action/AddToTree.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- AddToTree.java 19 Oct 2003 22:26:08 -0000 1.10
+++ AddToTree.java 20 Oct 2003 23:57:24 -0000 1.11
@@ -69,7 +69,7 @@
import org.apache.log.Logger;
/**
- * @author
+ * @author unattributed
* @version $Revision$ Last updated: $Date$
*/
public class AddToTree implements Command
1.12 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java
Index: ClientJMeterEngine.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/engine/ClientJMeterEngine.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- ClientJMeterEngine.java 19 Oct 2003 22:22:22 -0000 1.11
+++ ClientJMeterEngine.java 20 Oct 2003 23:57:24 -0000 1.12
@@ -66,7 +66,7 @@
/**
- * @author
+ * @author unattributed
* @version $Revision$ Updated on: $Date$
*/
public class ClientJMeterEngine implements JMeterEngine,Runnable
1.6 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/gui/util/TextAreaTableCellEditor.java
Index: TextAreaTableCellEditor.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/util/TextAreaTableCellEditor.java,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -r1.5 -r1.6
--- TextAreaTableCellEditor.java 27 Jun 2003 20:37:40 -0000 1.5
+++ TextAreaTableCellEditor.java 20 Oct 2003 23:57:24 -0000 1.6
@@ -101,7 +101,7 @@
/**
* Returns the number of clicks needed to start editing.
- * @returns the number of clicks needed to start editing
+ * @return the number of clicks needed to start editing
*/
public int getClickCountToStart()
{
1.5 +3 -3
jakarta-jmeter/src/core/org/apache/jmeter/threads/ReflectionThreadGroup.java
Index: ReflectionThreadGroup.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/threads/ReflectionThreadGroup.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- ReflectionThreadGroup.java 28 Jun 2003 19:35:40 -0000 1.4
+++ ReflectionThreadGroup.java 20 Oct 2003 23:57:24 -0000 1.5
@@ -56,11 +56,11 @@
/**
* ThreadGroup used for reflection purposes. [EMAIL PROTECTED] ThreadGroup} has a
- * [EMAIL PROTECTED] LoopController} which loops as many times as specified on the
+ * [EMAIL PROTECTED] org.apache.jmeter.control.LoopController} which loops as many
times as specified on the
* ThreadGroup gui. During reflection, we don't need the
* <code>LoopController</code> because we need to run the Sampler (for example,
* <code>JNDISampler</code>) only once. Thus we create this
- * <code>ReflectionThreadGroup</code> which has a [EMAIL PROTECTED] #nextEntry()}
+ * <code>ReflectionThreadGroup</code> which has a {link #nextEntry()}
* which doesn't make use of the <code>LoopController</code>.
*
* @author Khor Soon Hin
1.38 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/threads/JMeterThread.java
Index: JMeterThread.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/threads/JMeterThread.java,v
retrieving revision 1.37
retrieving revision 1.38
diff -u -r1.37 -r1.38
--- JMeterThread.java 19 Oct 2003 22:33:57 -0000 1.37
+++ JMeterThread.java 20 Oct 2003 23:57:24 -0000 1.38
@@ -82,7 +82,7 @@
* The JMeter interface to the sampling process, allowing JMeter to see the
* timing, add listeners for sampling events and to stop the sampling process.
*
- * @author
+ * @author unattributed
* @version $Revision$ Last updated: $Date$
*/
public class JMeterThread implements Runnable, java.io.Serializable
1.5 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/testelement/property/NullProperty.java
Index: NullProperty.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testelement/property/NullProperty.java,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- NullProperty.java 29 Sep 2003 14:56:01 -0000 1.4
+++ NullProperty.java 20 Oct 2003 23:57:24 -0000 1.5
@@ -54,7 +54,7 @@
}
/**
- * @see JMeterProperty#isTemporary(TestElement)
+ * see JMeterProperty#isTemporary(TestElement)
*/
public boolean isTemporary(TestElement owner)
{
1.25 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java
Index: AbstractJMeterGuiComponent.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java,v
retrieving revision 1.24
retrieving revision 1.25
diff -u -r1.24 -r1.25
--- AbstractJMeterGuiComponent.java 27 Jun 2003 21:48:13 -0000 1.24
+++ AbstractJMeterGuiComponent.java 20 Oct 2003 23:57:24 -0000 1.25
@@ -79,7 +79,7 @@
* other abstract classes that create different classes of GUI components for
* JMeter (Visualizers, Timers, Samplers, Modifiers, Controllers, etc).
*
- * @see JMeterGUIComponent
+ * @see org.apache.jmeter.gui.JMeterGUIComponent
* @see org.apache.jmeter.config.gui.AbstractConfigGui
* @see org.apache.jmeter.assertions.gui.AbstractAssertionGui
* @see org.apache.jmeter.control.gui.AbstractControllerGui
1.20 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java
Index: AbstractVisualizer.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/visualizers/gui/AbstractVisualizer.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- AbstractVisualizer.java 9 Jul 2003 21:20:38 -0000 1.19
+++ AbstractVisualizer.java 20 Oct 2003 23:57:24 -0000 1.20
@@ -269,7 +269,7 @@
/**
* This provides a convenience for extenders when they implement the
- * [EMAIL PROTECTED] JMeterGUIComponent#createTestElement()} method. This
method
+ * [EMAIL PROTECTED]
org.apache.jmeter.gui.JMeterGUIComponent#createTestElement()} method. This method
* will set the name, gui class, and test class for the created Test
* Element. It should be called by every extending class when creating
* Test Elements, as that will best assure consistent behavior.
1.11 +2 -2
jakarta-jmeter/src/core/org/apache/jmeter/reporters/FileReporter.java
Index: FileReporter.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/reporters/FileReporter.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- FileReporter.java 5 Oct 2003 01:05:31 -0000 1.10
+++ FileReporter.java 20 Oct 2003 23:57:24 -0000 1.11
@@ -191,7 +191,7 @@
*/
class graphPanel extends JPanel
{
- boolean autoScale = true;
+ //boolean autoScale = true;
Hashtable data;
Vector keys = new Vector();
Vector colorList = new Vector();
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
