sebb        2003/10/21 07:57:34

  Modified:    src/core/org/apache/jmeter/threads TestCompiler.java
  Log:
  Added some documentation; fixed some Javadoc comments
  
  Revision  Changes    Path
  1.35      +19 -13    
jakarta-jmeter/src/core/org/apache/jmeter/threads/TestCompiler.java
  
  Index: TestCompiler.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/threads/TestCompiler.java,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -r1.34 -r1.35
  --- TestCompiler.java 20 Oct 2003 12:18:43 -0000      1.34
  +++ TestCompiler.java 21 Oct 2003 14:57:34 -0000      1.35
  @@ -38,15 +38,22 @@
   public class TestCompiler implements HashTreeTraverser, SampleListener
   {
       transient private static Logger log = LoggingManager.getLoggerForClass();
  +    
  +    //TODO - should these variables be made private?
       LinkedList stack = new LinkedList();
       Map samplerConfigMap = new HashMap();
  -    Set objectsWithFunctions = new HashSet();
  +    //Set objectsWithFunctions = new HashSet();
       HashTree testTree;
  -    SampleResult previousResult;
  -    Sampler currentSampler;
  -    JMeterVariables threadVars;
  +    SampleResult previousResult;//TODO is this needed?
  +    Sampler currentSampler;//TODO is this needed?
  +    JMeterVariables threadVars;//TODO is this needed?
  +    
  +    /*
  +     * This set keeps track of which ObjectPairs have been seen
  +     * Its purpose is not entirely clear (please document if you know!)
  +     * but it is needed,..
  +     */
       private static Set pairing = new HashSet();
  -    //TODO: should pairing be static?
   
       List loopIterListeners = new ArrayList();
   
  @@ -55,7 +62,11 @@
           threadVars = vars;
           this.testTree = testTree;
       }
  -
  +    
  +    /**
  +     * Clears the pairing Set
  +     * Called by StandardJmeterEngine at the start of a test run.
  +     */
       public static synchronized void initialize()
       {
           pairing.clear();
  @@ -227,7 +238,6 @@
       }
   
       /**
  -     * @author    $Author$
        * @version   $Revision$
        */
       public static class Test extends junit.framework.TestCase
  @@ -273,10 +283,6 @@
           }
       }
   
  -    /**
  -     * @author    $Author$
  -     * @version   $Revision$
  -     */
       private class ObjectPair
       {
           TestElement child, parent;
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to