The patch problems may well have been due to the effects of the e-mail transport.
The patched code works for me as well - except when the file is loaded on the command-line. But then the code used to do that is different - for one thing, it does not set the file name for save operations. If one loads another file, the title will change to reflect the newly loaded file, which seems reasonable, as a save command will use the latest name, as far as I can tell. == By the way, just came across http://versiontree.sourceforge.net/ "The Eclipse Version Tree Plugin is an extension for the Eclipse IDE that displays a graphical tree for a CVS Resource. The Version Tree plugin is a user friendly substitute for the Revision History provided by Eclipse" Looks useful, but I've not tried it. S. > -----Original Message----- > From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED] > Sent: 16 December 2003 09:15 > To: JMeter Developers List > Subject: Re: [PATCH] Display current filename in title bar > > > May have been my fault. I'm used to diff/patch, but I was > using Eclipse, > which is new to me. I'll try harder next time. > > Anyway, it wasn't that long, and doing it manually helps > careful review. > > -- > Salut, > > Jordi. > > En/na Keith Lancaster ha escrit: > > Jordi, > > Interesting. I synced up to cvs right before doing the diff > by doing cvs > > update. Maybe I did something wrong...I've worked with > quite a number of > > CM systems, but am relatively new to CVS. Sorry you had to > do the work > > manually. > > Thanks, > > Keith > > > > Jordi Salvat i Alabart wrote: > > > >> Hi Keith, > >> > >> your patch worked flawlessly (as far as I tested it) on the first > >> shot, although it was not trivial to apply it -- had to do most by > >> hand. Maybe you didn't work from the latest CVS code? > You're welcome > >> to use that as the base for your next contribution -- but > please don't > >> stop your patches comming for this reason: we desperately > need people > >> to contribute to the GUI aspects of JMeter. > >> > >> Feel free to add your name to the contributor list in > >> http://nagoya.apache.org/wiki/apachewiki.cgi?JMeterCommitters > >> > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
