I don't know what kind of time frame you are thinking of, but this weekend I should have some time to play with it and check out the branch then. I've been swamped with stuff at work. by the way, thanks for cleaning up the accesslog gui stuff, I forget who did it. peter
"BAZLEY, Sebastian" <[EMAIL PROTECTED]> wrote: -----Original Message----- > From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED] > Sent: 07 January 2004 18:54 > To: JMeter Developers List > Subject: Tons of small changes in the testbeans branch. > > I will appreciate comments from anyone willing to spend the time to > synch the testbeans_experimental_branch. There's significant > GUI changes The GUI is coming along very nicely ... you've convinced me! > from the previous version, and as we all know, this is mostly > a matter > of tastes, so I need your comments there. In particular, the "Edit" > option in the combos is not a very nice solution... would a > small button > with an icon at the right of the field do the work better? Not sure what you mean by this. If a field has no predefined values (e.g. URL Path), it could be just a text field - no need for the combo box. It might look cleaner if "Undefined" was blank (one fewer translation to do ...!) > > I will also appreciate comments on code structure and hepl on > covering > some of the most relevant remaining TODOs: > - How do I sort out a GUI component that would like to grow (e.g. the > arguments table) from one that is perfectly happy at its current size? > - How can I safely warn the user when he enters a string that doesn't > look like a JMeter 'expression' (doesn't contain "${") and > the value is > not accepted by the property editor (e.g. a Boolean is not > true/false, > an Integer has letters, etc.) Tricky - evaluating it might have side effects ... > - TODO entries in the code (though some are already obsolete, > I need to > remove them). I'm happy to help if I can. One thing I would like to change is to allow as many fields as possible to be left undefined without causing NPEs - for example protocol should default to http. S. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------- Do you Yahoo!? Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes
