jsalvata 2004/01/08 14:58:09
Modified: src/protocol/http/org/apache/jmeter/protocol/http/sampler
Tag: testbeans_experimental_branch
HTTPSamplerBean.java
Log:
* Improved defaults (sebb: opinions?).
* Using new TestElement property assignement feature.
Revision Changes Path
No revision
No revision
1.1.2.5 +5 -26
jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/Attic/HTTPSamplerBean.java
Index: HTTPSamplerBean.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/sampler/Attic/HTTPSamplerBean.java,v
retrieving revision 1.1.2.4
retrieving revision 1.1.2.5
diff -u -r1.1.2.4 -r1.1.2.5
--- HTTPSamplerBean.java 7 Jan 2004 23:34:38 -0000 1.1.2.4
+++ HTTPSamplerBean.java 8 Jan 2004 22:58:09 -0000 1.1.2.5
@@ -86,7 +86,6 @@
import org.apache.jmeter.samplers.Sampler;
import org.apache.jmeter.testbeans.TestBean;
-import org.apache.jmeter.testelement.TestElement;
import org.apache.jmeter.testelement.property.CollectionProperty;
import org.apache.jmeter.testelement.property.PropertyIterator;
@@ -199,18 +198,18 @@
/*
* Public properties:
*/
- private String fileField= "";
+ private String fileField= ""; // TODO: is this valid? Choose a sensible default
or check it's non-null.
private File filename= null;
- private String protocol= "";
+ private String protocol= "http";
private String path= "";
private String encodedPath= "";
private boolean followRedirects= true;
- private String Method= "";
+ private String Method= "GET";
private boolean useKeepAlive= false;
private int port= UNSPECIFIED_PORT;
- private String domain= "";
+ private String domain= ""; // TODO: choose a sensible default or check it's
non-null.
private Arguments arguments= null;
- private String mimeType= "";
+ private String mimeType= ""; // TODO: is this valid? Choose a sensible one or
check it's non-null.
private boolean imageParser= false;
/*
@@ -248,26 +247,6 @@
arg.setAlwaysEncoded(false);
}
this.getArguments().addArgument(arg);
- }
-
- public void addTestElement(TestElement el)
- {
- if (el instanceof CookieManager)
- {
- setCookieManager((CookieManager)el);
- }
- else if (el instanceof HeaderManager)
- {
- setHeaderManager((HeaderManager)el);
- }
- else if (el instanceof AuthManager)
- {
- setAuthManager((AuthManager)el);
- }
- else
- {
- super.addTestElement(el);
- }
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
