jsalvata    2004/01/14 06:10:04

  Modified:    src/core/org/apache/jmeter/testbeans/gui Tag:
                        testbeans_experimental_branch WrapperEditor.java
  Log:
  Made sure we always remember the last valid value.
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.1.2.13  +11 -6     
jakarta-jmeter/src/core/org/apache/jmeter/testbeans/gui/Attic/WrapperEditor.java
  
  Index: WrapperEditor.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testbeans/gui/Attic/WrapperEditor.java,v
  retrieving revision 1.1.2.12
  retrieving revision 1.1.2.13
  diff -u -r1.1.2.12 -r1.1.2.13
  --- WrapperEditor.java        14 Jan 2004 12:53:28 -0000      1.1.2.12
  +++ WrapperEditor.java        14 Jan 2004 14:10:04 -0000      1.1.2.13
  @@ -319,8 +319,6 @@
   
        guiEditor.setValue(text);
        
  -     lastValidValue= text;
  -     
        firePropertyChange();
       }
   
  @@ -383,16 +381,23 @@
                // TODO: if (NOT A TAG: && noEdit) shouldNeverHappen();
       
                guiEditor.setValue(value);
  -    
  -             lastValidValue= value;
   
                firePropertyChange();
        }
   
       public void propertyChange(PropertyChangeEvent event)
       {
  -             if (! isValidValue(guiEditor.getAsText()))
  +     String text= guiEditor.getAsText();
  +             if (isValidValue(text))
  +             {
  +                     lastValidValue= text;
  +             }
  +             else
                {
  +                     if (log.isDebugEnabled())
  +                     {
  +                             log.debug("Invalid value. Reverting to last valid 
value.");
  +                     }
                        // TODO: warn the user. Maybe with a pop-up? A bell?
       
                        // Revert to the previously unselected (presumed valid!) value:
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to