sebb 2004/06/06 15:16:59
Modified: src/core/org/apache/jmeter/threads TestCompiler.java
src/core/org/apache/jmeter/testbeans BeanInfoSupport.java
Log:
Reduce visibility of fields; comment out unread fields
Revision Changes Path
1.41 +13 -14
jakarta-jmeter/src/core/org/apache/jmeter/threads/TestCompiler.java
Index: TestCompiler.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/threads/TestCompiler.java,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- TestCompiler.java 21 May 2004 21:09:45 -0000 1.40
+++ TestCompiler.java 6 Jun 2004 22:16:59 -0000 1.41
@@ -58,14 +58,13 @@
{
transient private static Logger log = LoggingManager.getLoggerForClass();
- //TODO - should these variables be made private?
- LinkedList stack = new LinkedList();
- Map samplerConfigMap = new HashMap();
+ private LinkedList stack = new LinkedList();
+ private Map samplerConfigMap = new HashMap();
//Set objectsWithFunctions = new HashSet();
- HashTree testTree;
- SampleResult previousResult;//TODO is this needed?
- Sampler currentSampler;//TODO is this needed?
- JMeterVariables threadVars;//TODO is this needed?
+ private HashTree testTree;
+ //NOTREAD SampleResult previousResult;
+ //NOTREAD Sampler currentSampler;
+ //NOTREAD JMeterVariables threadVars;
/*
* This set keeps track of which ObjectPairs have been seen
@@ -78,7 +77,7 @@
public TestCompiler(HashTree testTree, JMeterVariables vars)
{
- threadVars = vars;
+ //NOTREAD threadVars = vars;
this.testTree = testTree;
}
@@ -96,7 +95,7 @@
public void sampleOccurred(SampleEvent e)
{
- previousResult = e.getResult();
+ //NOTREAD previousResult = e.getResult();
}
public void sampleStarted(SampleEvent e)
@@ -109,7 +108,7 @@
public SamplePackage configureSampler(Sampler sampler)
{
- currentSampler = sampler;
+ //NOTREAD currentSampler = sampler;
SamplePackage pack = (SamplePackage) samplerConfigMap.get(sampler);
pack.setSampler(sampler);
runPreProcessors(pack.getPreProcessors());
@@ -315,7 +314,7 @@
}
}
- private class ObjectPair
+ private class ObjectPair //TODO - should this be static?
{
TestElement child, parent;
1.8 +4 -4
jakarta-jmeter/src/core/org/apache/jmeter/testbeans/BeanInfoSupport.java
Index: BeanInfoSupport.java
===================================================================
RCS file:
/home/cvs/jakarta-jmeter/src/core/org/apache/jmeter/testbeans/BeanInfoSupport.java,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- BeanInfoSupport.java 28 May 2004 21:09:12 -0000 1.7
+++ BeanInfoSupport.java 6 Jun 2004 22:16:59 -0000 1.8
@@ -83,7 +83,7 @@
GenericTestBeanCustomizer.RESOURCE_BUNDLE;
/** The class for which we're providing the bean info. */
- private Class beanClass;
+ //NOTREAD private Class beanClass;
/** The BeanInfo for our class as obtained by the introspector. */
private BeanInfo rootBeanInfo;
@@ -95,7 +95,7 @@
* Construct a BeanInfo for the given class.
*/
protected BeanInfoSupport(Class beanClass) {
- this.beanClass= beanClass;
+ //NOTREAD this.beanClass= beanClass;
try {
rootBeanInfo= Introspector.getBeanInfo(
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
