It's just possible that the class is only used by one thread - but I rather suspect not.
== As to Java 1.5, the main branch is starting to use 1.5 features. According to our recent mini-survey, the majority of JMeter users are on 1.4, and some platforms don't have 1.5 yet, so we're not proposing to move the 2.1 branch to 1.5. S. On 07/09/05, studdugie <[EMAIL PROTECTED]> wrote: > It should most definately be because the consumers of this object are > neglecting the fact that it's not supposed to be thread safe therefore it's > there responsiblity to synchronize correctly. On the other hand, from what > I've seen it seems pretty thread safe (when patched) so I'm not sure how > much more thread safe you could make it. Finally, I notice that there is a > newer version that's using JDK 1.5 features. If you have anything to do w/ > that I would like to point out that SamplingStatCalculator is a class that > can take advantage of 1.5 features to maintain thread safety yet increase > concurrency w/o excessive use of the synchronized keyword. Just my 2 cents. > > > > On 9/7/05, sebb <[EMAIL PROTECTED]> wrote: > > Also, the StatCalculator class is documented as being not thread-safe, > > yet access is not always synchronised. Perhaps it needs to be? > > > > S. > > On 07/09/05, sebb <[EMAIL PROTECTED] > wrote: > > > Not quite sure why you changed ArrayList to Vector in > > > SamplingStatCalculator.java. > > > > > > Was it to avoid some additional synchronisation, e.g. in methods such > > > as getSample() ? > > > > > > S. > > > On 07/09/05, studdugie <[EMAIL PROTECTED]> wrote: > > > > I've posted the patch as promised but I'm unsubscribing from the list. > If > > > > anyone has any questions, comments, or concerns about the patches > please > > > > email me directly at this email address. > > > > > > > > Thank you. > > > > > > > > Dane > > > > > > > > On 9/7/05, Michael Stover <[EMAIL PROTECTED] > wrote: > > > > > > > > > > 2.1.1 : +1 > > > > > > > > > > On Tue, 2005-09-06 at 17:56 -0400, Peter Lin wrote: > > > > > > I vote for 2.1.1 > > > > > > > > > > > > > > > > > > peter > > > > > > > > > > > > > > > > > > On 9/6/05, sebb <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > > > I would think within a week or so, depends on what else would be > worth > > > > > > > fixing, plus finding time to do the build, collect votes etc. > > > > > > > > > > > > > > By the way, what should it be called? > > > > > > > > > > > > > > 2.1.1 or 2.2 or ? > > > > > > > > > > > > > > It would be useful to decide that so Bugzilla can be updated in > > > > > > > advance - should probably get the next version added at the same > time. > > > > > > > > > > > > > > S. > > > > > > > On 06/09/05, Peter Lin <[EMAIL PROTECTED]> wrote: > > > > > > > > I need to write some graph classes to produce the charts and > graphs, > > > > > so > > > > > > > I > > > > > > > > thought I might as well extend the aggregate listener. When do > we > > > > > plan > > > > > > > on > > > > > > > > releasing a new version of 2.1? > > > > > > > > > > > > > > > > peter > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > > > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
