I've uploaded the changes anyway, and created a new nightly build.

S.

On 22/10/05, sebb <[EMAIL PROTECTED]> wrote:
> On 21/10/05, Thomas Kessler <[EMAIL PROTECTED]> wrote:
> > Hi!
> >
> > > >     socket connection for all HTTPSamplers in a thread
> > > >  * Cookies were not delivered the correct way
> >
> > > What was the problem with the cookies?
> >
> > HTTPClient requires Cookies to be added to HTTPState.
> >
> > > > I've made a quick an dirty patch for that issues, please find attached 
> > > > the modified class HTTPSampler2.java.
> >
> > > In future we'd prefer these as attachments to a Bugzilla issue please
> > > - makes it easier to keep track of them, and does not overload the
> > > mailing list.
> >
> > ok, I'll do so...
> >
>
> I've been looking at the code, and there are some things I don't understand:
>
> Not sure why you used addRequestHeader() for the following headers:
>
> "Connection"
> "Authorization"
>
> as there is surely only supposed to be at most one of each of these?
>
> I've replaced them with setRequestHeader().
>
> Also, I'm not sure that Cookie handling is correct - only Cookies with
> getExpires() == 0 are being sent - surely one needs to also send ones
> where the Expiry date has not yet been reached?
>
> S.
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to