you know way more about subversion than I do.. so I'll defer to your knowledge :)
peter On 11/3/05, sebb <[EMAIL PROTECTED]> wrote: > > SVN definitely swallows up everything from $Revision: to the 1st $ it > finds. > It's not a feature of Subclipse, because I tried it on minotaur in the > test repo. > > This may well be deliberate (*), and it's possible that CVS does this > too - the problem only occured with SVN, but then I only added the // > $NON-NLS-1$ marker once we had moved to SVN. > > (*) in the case of $Revision, it "knows" that there can only be > spaces, digits or "." between the ":" and the trailing "$", but this > is not so obvious for some of the other markers, for example $Id:, > which has several fields. > > So it looks like my error - or at least my ignorance... > > S. > On 03/11/05, Peter Lin <[EMAIL PROTECTED]> wrote: > > it's the wonderful part of switching to CVS. thing that used to work now > get > > to break. > > > > peter > > > > > > On 11/3/05, sebb <[EMAIL PROTECTED]> wrote: > > > > > > Just tried again, and the comment is being swallowed by the string. > > > > > > I'll fix it by removing it, and try raising an SVN bug. > > > > > > S. > > > On 03/11/05, Peter Lin <[EMAIL PROTECTED]> wrote: > > > > ok, sounds cool :) > > > > > > > > peter > > > > > > > > > > > > On 11/3/05, sebb <[EMAIL PROTECTED]> wrote: > > > > > > > > > > Something similar happened to me. > > > > > > > > > > The "// $NON-NLS-1$" comment appears to have been swallowed by the > > > string. > > > > > > > > > > I'll remove it. > > > > > > > > > > The idea is to split the CVS marker "$Revision: n.mm <http://n.mm>< > http://n.mm> < > > > http://n.mm> $" into > > > > > a prefix > > > > > and a suffix, so one can extract the n.mm <http://n.mm> < > http://n.mm> <http://n.mm> > > > (or nnnnnn in the > > > > > case of > > > > > SVN) but it looks like this is hitting an SVN or possibly > Subclipse > > > > > bug. > > > > > > > > > > BTW, the // $NON-NLS-1$ comment is intended to tell Eclipse that > the > > > > > string is non-language specific - i.e. it does not have to be > > > > > translated for localisation purposes. > > > > > > > > > > S. > > > > > On 03/11/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > > > Author: woolfel > > > > > > Date: Wed Nov 2 19:30:20 2005 > > > > > > New Revision: 330428 > > > > > > > > > > > > URL: http://svn.apache.org/viewcvs?rev=330428&view=rev > > > > > > Log: > > > > > > after I updated from SVN, the string appeared to be missing > > > > > > > > > > > > the closing double quote and semicolon. fixing it so it > > > > > > > > > > > > compiles > > > > > > > > > > > > peter lin > > > > > > > > > > > > Modified: > > > > > > > > > > > > > > > jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/SaveService.java > > > > > > > > > > > > Modified: > > > > > > > > > jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/SaveService.java > > > > > > URL: > > > > > > > > > http://svn.apache.org/viewcvs/jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/SaveService.java?rev=330428&r1=330427&r2=330428&view=diff > > > > > > > > > > > > > > > ============================================================================== > > > > > > --- > > > > > > > > > jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/SaveService.java > > > > > (original) > > > > > > +++ > > > > > > > > > jakarta/jmeter/branches/rel-2-1/src/core/org/apache/jmeter/save/SaveService.java > > > > > Wed Nov 2 19:30:20 2005 > > > > > > @@ -240,7 +240,7 @@ > > > > > > > > > > > > // Extract version digits from String of the form #Revision: > n.mm <http://n.mm><http://n.mm> > > > <http://n.mm># > > > > > > // (where # is actually $ above) > > > > > > - private static final String REVPFX = "$Revision$NON-NLS-1$ > > > > > > + private static final String REVPFX = "$Revision$NON-NLS-1$"; > > > > > > > > > > > > private static final String REVSFX = " $"; // $NON-NLS-1$ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > > > > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
