New files can be provided as patches, but it is usually easier to provide the source.
Please ensure that you include the ASF license header; thanks. S. On 27/02/07, Two Hawk <[EMAIL PROTECTED]> wrote:
Hi Thanks for your comments. My reason for validating the xml against the schema is only to be sure that it is an xml-rpc call and not just some xml being posted. The alternative is to call the feature isXmlData, not isXmlRpc, and then skip the parsing and schema checking? Also, i will fix my code according to your comments asap, and repost my files on bugzilla. A quick question regarding my bugzilla post; should new files (xml-rpc.xsd and XmlRpcErrorHandler.java) go as patches or ...? /Jesper >From: sebb <[EMAIL PROTECTED]> >Reply-To: "JMeter Developers List" <[email protected]> >To: "JMeter Developers List" <[email protected]> >Subject: Re: HTTP Proxy with XML-RPC >Date: Mon, 26 Feb 2007 18:26:40 +0000 > >Thanks. > >Just wondering why the query string needs to be compared against a schema? > >If the content starts with <?xml surely this means that the string >should not be parsed into name/value pairs? > >Or am I missing something here? > >Unless the DOM parsing is needed, it would obviously be a lot cheaper >to omit it. > >Some minor issues: >- unless the DOMParser is thread-safe, one cannot use a static copy. >- catch Exception is not a good idea; one should only catch expected errors >- should probably use log.warn rather than log.debug for logging the >exception. > >S. >On 26/02/07, Two Hawk <[EMAIL PROTECTED]> wrote: >>Hi >> >>My code is now submitted to bugzilla as #41707. Looking forward to hear >>your >>reactions/comments ... >> >>/Jesper >> >> >From: sebb <[EMAIL PROTECTED]> >> >Reply-To: "JMeter Developers List" <[email protected]> >> >To: "JMeter Developers List" <[email protected]> >> >Subject: Re: HTTP Proxy with XML-RPC >> >Date: Sun, 25 Feb 2007 18:36:14 +0000 >> > >> >Thanks! Sounds useful. >> > >> >Please create a Bugzilla enhancement issue describing the code. >> > >> >You can then add any patches or new code as attachments to the issue. >> > >> >Please ensure that any patches are in unified diff format (as >> >generated by Eclipse), and are generated against branches/rel-2-2, not >> >the trunk, which is very out of date. >> > >> >On 24/02/07, Two Hawk <[EMAIL PROTECTED]> wrote: >> >>Hi >> >> >> >>I have added some code to allow xml-rpc communication to be recorded >> >>correctly when using the http proxy. Would anyone be interested in >>adding >> >>this to the codebase? If yes, how do i proceed from here? >> >> >> >>Best regards, >> >>Jesper >> >> >> >>_________________________________________________________________ >> >>Download din yndlingsmusik på MSN Music: http://www.msn.dk/music - >>det >> >>er >> >>nemt og billigt >> >> >> >> >> >>--------------------------------------------------------------------- >> >>To unsubscribe, e-mail: [EMAIL PROTECTED] >> >>For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> >> >> > >> >--------------------------------------------------------------------- >> >To unsubscribe, e-mail: [EMAIL PROTECTED] >> >For additional commands, e-mail: [EMAIL PROTECTED] >> > >> >>_________________________________________________________________ >>Ta' på udsalg året rundt på MSN Shopping: http://shopping.msn.dk - her >>finder du altid de bedste priser >> >> >>--------------------------------------------------------------------- >>To unsubscribe, e-mail: [EMAIL PROTECTED] >>For additional commands, e-mail: [EMAIL PROTECTED] >> >> > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > _________________________________________________________________ Del dine store filer uden problemer på MSN Messenger: http://messenger.msn.dk/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
