DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=25441>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=25441





------- Additional Comments From [EMAIL PROTECTED]  2007-05-08 01:55 -------
(In reply to comment #5)
> Thanks - that's helped quite a bit. Applied in r535891.
> 
> However, there's still a problem with plans being incorrectly marked as dirty.
> 
> Test Plan
> - Simple Data Writer
> Save the plan.
> 
> Open the plan.
> Close the plan - no dialog box appears.
> 
> Open the plan, select the Simple Data Writer.
> Close the plan - the Save? dialogue appears.
> Same happens if you Resave the test plan - merely viewing the SDW causes the 
> plan to be marked dirty.
> Not sure what is going on here (yet), but at least there is a simple test 
> case!


All the Visualizers have this problem. If you select a Visualizer in the tree,
the test plan is then set as dirty by the CheckDirty action.
The reason is that AbstractVisualizer does a clone of the 
SampleSaveConfiguration :
collector.setSaveConfig((SampleSaveConfiguration) rc.getSaveConfig().clone());

When CheckDirty then checks the visualizer node, the "previous" and "current"
value is always different, because the "current" node has got a new
SampleSaveConfiguration.

One way of solving this would be to implement the "equals" method of
SampleSaveConfiguration, and then also the "hashCode" method.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to